Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETCD-714: Rebase etcd 3.5.18 openshift 4.17 #310

Open
wants to merge 70 commits into
base: openshift-4.17
Choose a base branch
from

Conversation

Elbehery
Copy link

This PR rebases etcd 3.5.18 into openshift-4.17.

running make locally

SUCCESS: etcd_build (GOARCH=arm64)
./bin/etcd --version
etcd Version: 3.5.18
Git SHA: 8333233f3
Go Version: go1.22.11
Go OS/Arch: darwin/arm64
./bin/etcdctl version
etcdctl version: 3.5.18
API version: 3.5
./bin/etcdutl version
etcdutl version: 3.5.18
API version: 3.5

cc @openshift/openshift-team-etcd

ghouscht and others added 30 commits September 12, 2024 08:43
docs: remove warning that etcd 3.5.0 was not yet released
…ry-pick-18592-to-release-3.5

[3.5] Ensure commits are signed in `scripts/release.sh`
GitHub Container Registry is returning a TOOMANYREQUESTS error. Switch
to AWS ECR mirror, as suggested in
aquasecurity/trivy-action#389.

Signed-off-by: Ivan Valdes <[email protected]>
…ry-pick-18672-to-release-3.5

[3.5] github/workflows: use ECR mirror for Trivy's DB
Remove defunct release-3.5 arm64 github actions workflows
[3.5] [serverWatchStream] terminate recvLoop on sws.close()
[3.5] manual: Fix risk of a partial write txn being applied
…logs-test

[3.5] chore(e2e): backport TestNoErrorLogsDuringNormalOperations test
[3.5] fix(defrag): handle errors during defrag
Signed-off-by: Ivan Valdes <[email protected]>
…temp-3.5

[3.5] fix(defrag): close temp file in case of error
Currently, the script won't change directories into the previously
cloned repository if the temporary location exists. This may be an issue
when testing first with a dry run and later with the actual release.

Signed-off-by: Ivan Valdes <[email protected]>
Backport pull request etcd-io#18649.

Signed-off-by: Ivan Valdes <[email protected]>
[3.5] release: use GitHub's gh to create GitHub release
[3.5] release: properly change working dir if tmp location already exists
Signed-off-by: Ivan Valdes <[email protected]>
tjungblu and others added 3 commits February 26, 2025 21:24
force-new-cluster seems to have similar watch cache issues as the
ordinary snapshot restore. This PR introduces the already existing utl logic
as a separate package into the server-side code.

This will only introduce a revbump flag, but under the hood implement
both rev bumping and compaction markers.

Signed-off-by: Thomas Jungblut <[email protected]>
This adds the min and max TLS version support from etcd-io#13506 and etcd-io#15156 to the grpc proxy.

Signed-off-by: Thomas Jungblut <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 26, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2025

@Elbehery: This pull request references ETCD-714 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.z" version, but no target version was set.

In response to this:

This PR rebases etcd 3.5.18 into openshift-4.17.

running make locally

SUCCESS: etcd_build (GOARCH=arm64)
./bin/etcd --version
etcd Version: 3.5.18
Git SHA: 8333233f3
Go Version: go1.22.11
Go OS/Arch: darwin/arm64
./bin/etcdctl version
etcdctl version: 3.5.18
API version: 3.5
./bin/etcdutl version
etcdutl version: 3.5.18
API version: 3.5

cc @openshift/openshift-team-etcd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Elbehery
Copy link
Author

/payload 4.17 nightly informing

@Elbehery
Copy link
Author

/payload 4.17 nightly blocking

@Elbehery
Copy link
Author

/assign @sdodson

Copy link

openshift-ci bot commented Feb 26, 2025

@Elbehery: trigger 9 job(s) of type blocking for the nightly release of OCP 4.17

  • periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.17-fips-payload-scan
  • periodic-ci-openshift-release-master-ci-4.17-upgrade-from-stable-4.16-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6267cb70-f482-11ef-9dac-083530b891d8-0

Copy link

openshift-ci bot commented Feb 26, 2025

@Elbehery: trigger 67 job(s) of type informing for the nightly release of OCP 4.17

  • periodic-ci-openshift-release-master-nightly-4.17-e2e-agent-compact-fips
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-agent-ha-dualstack-conformance
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-agent-single-node-ipv6
  • periodic-ci-openshift-release-master-nightly-4.17-console-aws
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.17-periodics-e2e-aws
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-csi
  • periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-cgroupsv2
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-fips
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-single-node-csi
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-single-node-serial
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-single-node-techpreview
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-single-node-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.17-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.17-upgrade-from-stable-4.16-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade-out-of-change
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-upi
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.17-periodics-e2e-azure
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-azure-csi
  • periodic-ci-openshift-release-master-ci-4.17-e2e-azure-ovn
  • periodic-ci-openshift-release-master-ci-4.17-e2e-azure-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.17-e2e-azure-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.17-e2e-azure-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.17-e2e-azure-ovn-upgrade-out-of-change
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-driver-toolkit
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.17-periodics-e2e-gcp
  • periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-gcp-ovn-csi
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-gcp-ovn-rt
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-gcp-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.17-upgrade-from-stable-4.16-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-bm-upgrade
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-dualstack
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-dualstack-techpreview
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-ipv6-techpreview
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-serial-ipv4
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-serial-virtualmedia
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-techpreview
  • periodic-ci-openshift-release-master-nightly-4.17-upgrade-from-stable-4.16-e2e-metal-ipi-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-serial-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-serial-ovn-dualstack
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-upgrade-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.17-upgrade-from-stable-4.16-e2e-metal-ipi-upgrade-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ovn-assisted
  • periodic-ci-openshift-release-master-nightly-4.17-metal-ovn-single-node-recert-cluster-rename
  • periodic-ci-openshift-osde2e-main-nightly-4.17-osd-aws
  • periodic-ci-openshift-osde2e-main-nightly-4.17-osd-gcp
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-proxy
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ovn-single-node-live-iso
  • periodic-ci-openshift-osde2e-main-nightly-4.17-rosa-classic-sts
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-telco5g
  • periodic-ci-openshift-release-master-ci-4.17-upgrade-from-stable-4.16-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-ovn
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-ovn-csi
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-ovn-serial
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-ovn-techpreview
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.17-upgrade-from-stable-4.16-e2e-vsphere-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-ovn-upi
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-ovn-upi-serial
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-static-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5d966d40-f482-11ef-963e-c0d9f0984a12-0

@openshift-ci openshift-ci bot requested review from deads2k and hexfusion February 26, 2025 20:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2025
@Elbehery
Copy link
Author

Copy link

openshift-ci bot commented Feb 26, 2025

@Elbehery: Overrode contexts on behalf of Elbehery: ci/prow/configmap-scale

In response to this:

/override ci/prow/configmap-scale

perma failing job https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-openshift-etcd-openshift-4.17-configmap-scale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Elbehery
Copy link
Author

/assign @dusk125

@Elbehery
Copy link
Author

/retest-required

@Elbehery
Copy link
Author

/override ci/prow/configmap-scale

@Elbehery
Copy link
Author

/retest-required

Copy link

openshift-ci bot commented Feb 27, 2025

@Elbehery: Overrode contexts on behalf of Elbehery: ci/prow/configmap-scale

In response to this:

/override ci/prow/configmap-scale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Elbehery
Copy link
Author

/retest-required

@dusk125
Copy link

dusk125 commented Feb 27, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2025
Copy link

openshift-ci bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, Elbehery

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Elbehery
Copy link
Author

/retest-required

2 similar comments
@Elbehery
Copy link
Author

/retest-required

@Elbehery
Copy link
Author

/retest-required

Copy link

openshift-ci bot commented Feb 28, 2025

@Elbehery: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery 8333233 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-hypershift 8333233 link false /test e2e-hypershift
ci/prow/e2e-aws-ovn-serial 8333233 link true /test e2e-aws-ovn-serial
ci/prow/configmap-scale 8333233 link true /test configmap-scale
ci/prow/e2e-aws-ovn 8333233 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.